xfs
[Top] [All Lists]

Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 28 Sep 2012 08:52:48 +1000
Cc: xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
In-reply-to: <20120927124742.695778439@xxxxxxx>
References: <20120925142414.660506845@xxxxxxx> <20120925142421.398175185@xxxxxxx> <20120926220434.GG13214@xxxxxxx> <20120927124742.695778439@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 27, 2012 at 07:47:36AM -0500, Mark Tinguely wrote:
> The vector feature of xfs_io uses its own memory buffer in the iov structure
> and does not use the buffer entry. Remove the duplicate memalign.
> 
> v2: removed global buffer in __dump_buffer() and use passed buf pointer per
>     Ben's detection.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

Looks good, Thanks for fixing this.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>