Re: [PATCH] xfsprog: remove duplicate vector memalign from xfs_io

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Wed, Sep 26, 2012 at 05:04:34PM -0500, Ben Myers wrote:
> On Tue, Sep 25, 2012 at 09:24:15AM -0500, Mark Tinguely wrote:
> > The vector feature of xfs_io uses its own memory buffer in the iov structure
> > and does not use the buffer entry. Remove the duplicate memalign.
> 
> Looks to me that there is a usage of buffer in __dump_buffer.  However,
> I suspect there shouldn't be.  I suggest (untested,ymmv,ianal,etc):
> 
> :!quilt di
> Index: xfsprogs/io/pread.c
> ===================================================================
> --- xfsprogs.orig/io/pread.c
> +++ xfsprogs/io/pread.c
> @@ -130,7 +130,7 @@ __dump_buffer(
>         int             i, j;
>         char            *p;
>  
> -       for (i = 0, p = (char *)buffer; i < len; i += 16) {
> +       for (i = 0, p = (char *)buf; i < len; i += 16) {
>                 char    *s = p;
>  
>                 printf("%08llx:  ", (unsigned long long)offset + i);

Can you post that as a proper patch?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx