xfs
[Top] [All Lists]

Re: [PATCH] xfsprog: remove duplicate vector memalign from xfs_io

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfsprog: remove duplicate vector memalign from xfs_io
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 27 Sep 2012 10:00:24 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120925142421.398175185@xxxxxxx>
References: <20120925142414.660506845@xxxxxxx> <20120925142421.398175185@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 25, 2012 at 09:24:15AM -0500, Mark Tinguely wrote:
> The vector feature of xfs_io uses its own memory buffer in the iov structure
> and does not use the buffer entry. Remove the duplicate memalign.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
> ---
>  io/pread.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: b/io/pread.c
> ===================================================================
> --- a/io/pread.c
> +++ b/io/pread.c
> @@ -76,8 +76,7 @@ alloc_iovec(
>       buffersize = 0;
>       for (i = 0; i < vectors; i++) {
>               iov[i].iov_base = memalign(pagesize, bsize);
> -             buffer = memalign(pagesize, bsize);
> -             if (!buffer) {
> +             if (!iov[i].iov_base) {
>                       perror("memalign");
>                       goto unwind;
>               }

Classic copy'n'paste bug. My fault.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>