xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: reduce code duplication handling inode32/64 options

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: reduce code duplication handling inode32/64 options
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 26 Sep 2012 15:20:48 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1348147961-7520-4-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1348147961-7520-1-git-send-email-cmaiolino@xxxxxxxxxx> <1348147961-7520-4-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/20/12 08:32, Carlos Maiolino wrote:
Add xfs_set_inode32() to be used to enable inode32 allocation mode. this will
reduce the amount of duplicated code needed to mount/remount a filesystem with
inode32 option.
This patch also changes xfs_set_inode64() to return the maximum AG number that
inodes can be allocated instead of set mp->m_maxagi by itself, so that the
behaviour is the same as xfs_set_inode32().
This simplifies code that calls these functions and needs to know the maximum
AG that inodes can be allocated in.

Signed-off-by: Carlos Maiolino<cmaiolino@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>