xfs
[Top] [All Lists]

Re: [PATCH] mkfs: Set a clean output in case of invalid inode size

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs: Set a clean output in case of invalid inode size
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 26 Sep 2012 13:12:21 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1334609816-8473-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1334609816-8473-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/16/12 15:56, Carlos Maiolino wrote:
Remove an unnecessary usage() call after a mkfs failure due an invalid inode
size.
A call to usage() at this point confuses the output message which may cause the
user to think it used wrong arguments to mkfs, instead of an invalid inode size.

Signed-off-by: Carlos Maiolino<cmaiolino@xxxxxxxxxx>
---


Found that this patch was reviewed but not committed.

Committed to git://oss.sgi.com/xfs/cmds/xfsprogs.git, master branch.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] mkfs: Set a clean output in case of invalid inode size, Mark Tinguely <=