xfs
[Top] [All Lists]

Re: [PATCH 4/6] xfs: Fix mp->m_maxagi update during inode64 remount

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 4/6] xfs: Fix mp->m_maxagi update during inode64 remount
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Tue, 25 Sep 2012 10:33:29 -0300
In-reply-to: <20120925093715.GF9189@xxxxxxxxxxxxx>
Mail-followup-to: xfs@xxxxxxxxxxx
References: <1348147961-7520-1-git-send-email-cmaiolino@xxxxxxxxxx> <1348147961-7520-5-git-send-email-cmaiolino@xxxxxxxxxx> <20120925093715.GF9189@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 25, 2012 at 05:37:15AM -0400, Christoph Hellwig wrote:
> On Thu, Sep 20, 2012 at 10:32:39AM -0300, Carlos Maiolino wrote:
> > With the changes made on xfs_set_inode64(), to make it behave as
> > xfs_set_inode32() (now leaving to the caller the responsibility to update
> > mp->m_maxagi), we use the return value of xfs_set_inode64() to update
> > mp->m_maxagi during remount.
> > 
> > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> 
> Shouldn;t this be part of the previous patch?
> 
> Otherwise looks good.
> 
dchinner suggested to keep small changes into different patches, once the
xfs_set_inode64() was added previously, adding a separate patche to add
xfs_set_inode32() and another one to change the behaviour of both functions
looks reasonable to me
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
--Carlos

<Prev in Thread] Current Thread [Next in Thread>