xfs
[Top] [All Lists]

Re: [PATCH v6] Stop periodic syncing if filesystem is already shutdown.

To: raghu.prabhu13@xxxxxxxxx
Subject: Re: [PATCH v6] Stop periodic syncing if filesystem is already shutdown.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Sep 2012 05:40:13 -0400
Cc: david@xxxxxxxxxxxxx, Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <143becf0f8266fbc8025ec97c8f44476d8fcafc5.1348203015.git.rprabhu@xxxxxxxxxxx>
References: <143becf0f8266fbc8025ec97c8f44476d8fcafc5.1348203015.git.rprabhu@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good, but one thing I'd love here is to actually print a useful
error for the typical EIO case, as the "error 5 occured" message just
confuses the heck out of people.  What it means is that we got an
EIO error from the block device, and that's what we should print.

Probably worth doing in a separate patch, so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>