xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: reduce code duplication handling inode32/64 options

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: reduce code duplication handling inode32/64 options
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Sep 2012 05:36:28 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1348147961-7520-4-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1348147961-7520-1-git-send-email-cmaiolino@xxxxxxxxxx> <1348147961-7520-4-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 20, 2012 at 10:32:38AM -0300, Carlos Maiolino wrote:
> Add xfs_set_inode32() to be used to enable inode32 allocation mode. this will
> reduce the amount of duplicated code needed to mount/remount a filesystem with
> inode32 option.
> This patch also changes xfs_set_inode64() to return the maximum AG number that
> inodes can be allocated instead of set mp->m_maxagi by itself, so that the
> behaviour is the same as xfs_set_inode32().
> This simplifies code that calls these functions and needs to know the maximum
> AG that inodes can be allocated in.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>