xfs
[Top] [All Lists]

Re: [PATCH 2/6] xfs: make inode64 as the default allocation mode

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH 2/6] xfs: make inode64 as the default allocation mode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 Sep 2012 05:35:56 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1348147961-7520-3-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1348147961-7520-1-git-send-email-cmaiolino@xxxxxxxxxx> <1348147961-7520-3-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 20, 2012 at 10:32:37AM -0300, Carlos Maiolino wrote:
> since 64-bit inodes can be accessed while using inode32, and these can also be
> used on 32-bit kernels, there is no reason to still keep inode32 as the 
> default
> mount option.
> If the filesystem cannot handle 64bit inode numbers (i.e CONFIG_LBDAF is not
> enabled and BITS_PER_LONG == 32), XFS_MOUNT_SMALL_INUMS will still be set by
> default, so inode64 is not an unconditional default value.

Btw, I think we should kill the !BIG_INUMS mode and just
require CONFIG_LBDAF on 32-bit, as the small in-core inums are 
codepath that rarely if ever is tested and not really useful these days.

But that should be a separate patch, so:


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>