xfs
[Top] [All Lists]

[PATCH 1/6] xfstests: add fio requirement V2

To: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Subject: [PATCH 1/6] xfstests: add fio requirement V2
From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Date: Mon, 24 Sep 2012 18:23:16 +0400
Cc: xfs@xxxxxxxxxxx, hch@xxxxxx, Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer; bh=Wnlc3BooUf8QxzyWuxHcA+IPsgJscqVM2B38aADzvRk=; b=dL7tK9JUZVLbsjM2+XJJUCplODZTrfeThmyLe+yA1s84rllZHD+J1LzHAIq9xrDMmJ 2AX/v3LxHmUsX/ZlBQANO47ax4lBUHd+DFnYcm8m5Jh/wNi7w2XFqvK0zF8/BTE1AkQP idCs0XpaTSokEJrpGNXLz8oXpEz4DchgIx+zstY9/EdULMlTNHzTMookn9CVHYCwx4QH Pr1i6VaLhvEoHJpP0VmJJzUF7W+CjQcVeOuoE7SOWAx4eae4NB3xyLCcuGbh9WJiwCbv jGAYaWQo3NekHH23ZHpKTQJKzGn+8vsvpzmoPtGDftNrADmdtncahhMZlO1I3BJZ7MLe JnHA==
Sender: Dmitry Monakhov <rjevskiy@xxxxxxxxx>
FIO is very flexible io generator, i would call it IO swiss knife.
Currently we have tonns of hardcoded application which reproduces
some predefined scenario. This approach has obvious dissadvantages
1) Lack of flexability: one written it is hard to modify it in future
2) Code base is large, many routines written again and again

At the same time add new fio based tast is just add simle INI file.
This greatly simplify code review. I do beleve that some day we will
replace most of hardcoded io binaries with fio.

One who is planning to run $FIO_PROG should first check that system
contains appropriate version which is able to handle jobfile
for example:  _require_fio 286-job.fio

Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
---
 common.config |    1 +
 common.rc     |   15 +++++++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/common.config b/common.config
index 7bed1c5..d5c8956 100644
--- a/common.config
+++ b/common.config
@@ -158,6 +158,7 @@ export XFS_QUOTA_PROG="`set_prog_path xfs_quota`"
 export KILLALL_PROG="`set_prog_path killall`"
 export INDENT_PROG="`set_prog_path indent`"
 export XFS_COPY_PROG="`set_prog_path xfs_copy`"
+export FIO_PROG="`set_prog_path fio`"
 
 # Generate a comparable xfsprogs version number in the form of
 # major * 10000 + minor * 100 + release
diff --git a/common.rc b/common.rc
index 602513a..f5027e7 100644
--- a/common.rc
+++ b/common.rc
@@ -1758,6 +1758,21 @@ _require_btrfs()
        [ $? -eq 0 ] || _notrun "$BTRFS_UTIL_PROG too old (must support $cmd)"
 }
 
+# Check that fio is present, and it is able to execute given jobfile
+_require_fio()
+{
+       job=$1
+
+       _require_command $FIO_PROG
+       if [ -z "$1" ]; then
+               return 1;
+       fi
+       
+       $FIO_PROG --warnings-fatal --showcmd $job >/dev/null 2>&1
+       [ $? -eq 0 ] || _notrun "$FIO_PROG too old"
+}
+
+
 # arg 1 is dev to remove and is output of the below eg.
 # ls -l /sys/class/block/sdd | rev | cut -d "/" -f 3 | rev
 _devmgt_remove()
-- 
1.7.7.6

<Prev in Thread] Current Thread [Next in Thread>