xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: restrict allocate worker to x86_64

To: tinguely@xxxxxxx
Subject: Re: [PATCH 1/3] xfs: restrict allocate worker to x86_64
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2012 07:54:05 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120919163145.367256258@xxxxxxx>
References: <20120919163133.097340199@xxxxxxx> <20120919163145.367256258@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 19, 2012 at 11:31:34AM -0500, tinguely@xxxxxxx wrote:
> Restrict the allocation worker to X86_64 machines. This will improve
> performance on non-X86-64 machines and avoid the AGF buffer hang.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

NACK.

The stack overflow problems that this works around are not limited
to x86-64. In the past we've seen overflows on i686 (even with 8k
stacks), s390 and other platforms, so it's not an isolated issue.

It either works or it doesn't - let's not start down the rathole of
having different code paths and behaviours for different platforms.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>