xfs
[Top] [All Lists]

Re: [RFC, PATCH 0/102]: xfs: 3.0.x stable kernel update

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [RFC, PATCH 0/102]: xfs: 3.0.x stable kernel update
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 19 Sep 2012 08:14:41 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120918235049.GB31501@dastard>
References: <1345698180-13612-1-git-send-email-david@xxxxxxxxxxxxx> <50587E28.7090704@xxxxxxx> <20120918235049.GB31501@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/18/12 18:50, Dave Chinner wrote:
On Tue, Sep 18, 2012 at 08:59:04AM -0500, Mark Tinguely wrote:
This looks great. Like I said earlier, I did not find Brian Foster's
log patch:
   xfs: check for stale inode before acquiring iflock on push
   Upstream commit: 9a3a5dab63461b84213052888bf38a962b22d035
sample implementation listed on:
   http://oss.sgi.com/archives/xfs/2012-09/msg00188.html

Reviewed-by: Mark Tinguely<tinguely@xxxxxxx>

Thatnks for looking over this, Mark.

The above patch does not directly apply to the 3.0.x branch because
the rework of the log item lock/push logic in the AIL was not
included in the series. Hence I'm not sure that backportingthis
patch is necessary because the problem only arose after we change
the locking/push logic...

Cheers,

Dave.

Hi Dave.

The original problem was in Linux 2.6.X.

The patch in the above link is a 3.0.42 port of Brian's top of tree
patch. This version places the tests in AIL trylock routine. We have
been using it on Linux 3.0.x for a couple months and it has avoided
the hangs that we used to get before.

Thank-you again for the work.

--Mark T.

<Prev in Thread] Current Thread [Next in Thread>