xfs
[Top] [All Lists]

Re: Test 272 fails for ext3

To: Jan Kara <jack@xxxxxxx>
Subject: Re: Test 272 fails for ext3
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 18 Sep 2012 16:26:40 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, dmonakhov@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120821080338.GA7537@xxxxxxxxxxxxx>
References: <20120816092808.GA9057@xxxxxxxxxxxxx> <20120816093757.GA11519@xxxxxxxxxxxxx> <20120816224858.GY2877@dastard> <20120820162212.GA17354@xxxxxxxxxxxxx> <20120820210638.GA4591@xxxxxxxxxxxxx> <20120820224941.GG19235@dastard> <20120821080338.GA7537@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Aug 21, 2012 at 10:03:39AM +0200, Jan Kara wrote:
> On Tue 21-08-12 08:49:41, Dave Chinner wrote:
> > On Mon, Aug 20, 2012 at 11:06:38PM +0200, Jan Kara wrote:
> > ....
> > > --- a/272
> > > +++ b/272
> > > @@ -32,15 +32,18 @@ tmp=/tmp/$$
> > >  status=1 # failure is the default!
> > >  trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> > >  
> > > +write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
> > > +if [ $FSTYP = "ext3" ]; then
> > > + # ext3 doesn't support direct IO in journalling mode
> > > + write_opt_list="iflag=noatime conv=notrunc conv=fsync"
> > > +fi
> > 
> > Seems like asking for trouble duplicating the common options.
> > 
> > # ext3 doesn't support direct IO in journalling mode
> > write_opt_list="iflag=noatime conv=notrunc conv=fsync
> > [ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
> > 
> > Otherwise looks fine.
> > 
> > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
>   OK, I've updated the test as you suggested. Result is attached.

Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: Test 272 fails for ext3, Ben Myers <=