xfs
[Top] [All Lists]

Re: [PATCH] xfs: stop the sync worker before xfs_unmountfs

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfs: stop the sync worker before xfs_unmountfs
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 18 Sep 2012 08:28:06 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120913211847.GS3274@xxxxxxx>
References: <20120829134624.316257238@xxxxxxx> <20120829134628.835024558@xxxxxxx> <20120830002335.GB15292@dastard> <20120830172549.GG3274@xxxxxxx> <20120830223504.GE15292@dastard> <5040FF25.1010501@xxxxxxx> <20120901230824.GB6896@xxxxxxxxxxxxx> <20120912183347.GO3274@xxxxxxx> <20120912231406.GJ11511@dastard> <20120913164344.GV25175@xxxxxxx> <20120913211847.GS3274@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/13/12 16:18, Ben Myers wrote:
Cancel work of the xfs_sync_worker before teardown of the log in
xfs_unmountfs.  This prevents occasional crashes on unmount like so:
...
Signed-off-by: Ben Myers<bpm@xxxxxxx>

Index: xfs/fs/xfs/xfs_super.c
===================================================================
--- xfs.orig/fs/xfs/xfs_super.c
+++ xfs/fs/xfs/xfs_super.c
@@ -919,6 +919,7 @@ xfs_fs_put_super(
        struct xfs_mount        *mp = XFS_M(sb);

        xfs_filestream_unmount(mp);
+       cancel_delayed_work_sync(&mp->m_sync_work);
        xfs_unmountfs(mp);
        xfs_syncd_stop(mp);
        xfs_freesb(mp);



Tests successfully on all 3 of the machines that were crashing without the patch.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>