xfs
[Top] [All Lists]

Re: [PATCH 020/102] xfs: warn if direct reclaim tries to writeback pages

To: Mel Gorman <mgorman@xxxxxxx>
Subject: Re: [PATCH 020/102] xfs: warn if direct reclaim tries to writeback pages
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 14 Sep 2012 11:18:21 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <50532979.2070002@xxxxxxx>
References: <1345698180-13612-1-git-send-email-david@xxxxxxxxxxxxx> <1345698180-13612-21-git-send-email-david@xxxxxxxxxxxxx> <20120827181742.GA13970@xxxxxxxxxxxxx> <20120905113242.GL11266@xxxxxxx> <50523E20.5000508@xxxxxxx> <20120914094523.GD11266@xxxxxxx> <50532979.2070002@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/14/12 07:56, Mark Tinguely wrote:
On 09/14/12 04:45, Mel Gorman wrote:
On Thu, Sep 13, 2012 at 03:12:16PM -0500, Mark Tinguely wrote:

WARNING: at fs/xfs/linux-2.6/xfs_aops.c:961
xfs_vm_writepage+0x63c/0x6a0()
Hardware name: S2721-533 Thunder i7501 Pro
Modules linked in: ext4 jbd2 crc16
Pid: 12122, comm: cp Not tainted 3.0.42 #2

I ask because on 3.0.42 this warning is not present. This patch should
not be merged to 3.0-stable.


Correct. Linux-3.0.42 with Dave 102 patches, I removed patch 94 and 95
per list comments. I added Brian Foster's patch as 103 <below>

I am testing xfstest 109 and 273 in a loop for shutdown worker races -
none found yet. That message happened in the first loop, and never
occurred again.

And the machine was a x86_32 not 64.

PS. of course it reports only once... that is what the patch does.
    reboot the machine and it displays on first call to test 273.

 Does not happen on the x86_64 machine. Until I can duplicate it on
 another x86_32, less us assume there is something weird with that
 machine.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>