xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.

To: Tao Ma <tm@xxxxxx>
Subject: Re: [PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 14 Sep 2012 08:43:56 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1347620592-3420-1-git-send-email-tm@xxxxxx>
References: <1347620592-3420-1-git-send-email-tm@xxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:15.0) Gecko/20120824 Thunderbird/15.0
On 9/14/12 6:03 AM, Tao Ma wrote:
> From: Tao Ma <boyu.mt@xxxxxxxxxx>
> 
> After the volume is mkfsed, it should have no other files that
> need to be rmed. And what's more, it makes ext4 complain since
> lost+found is also removed.
> 
> So remove this useless "rm -rf $SCRATCH_MNT/*".

Oh, sigh, after all the review how did I miss that :/

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

SGI: I won't be pushing this to kernel.org trees per the emails yesterday.

Thanks,
-Eric

> Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>
> Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx>
> ---
>  275 |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/275 b/275
> index 69b2895..06db775 100755
> --- a/275
> +++ b/275
> @@ -57,8 +57,6 @@ umount $SCRATCH_DEV 2>/dev/null
>  _scratch_mkfs_sized $((2 * 1024 * 1024 * 1024)) >>$seq.full 2>&1
>  _scratch_mount
>  
> -rm -rf $SCRATCH_MNT/*
> -
>  dd if=/dev/zero of=$SCRATCH_MNT/tmp1 bs=256K count=1 >>$seq.full 2>&1
>  [ $? -ne 0 ] && _fail "Error creating file"
>  
> 

<Prev in Thread] Current Thread [Next in Thread>