xfs
[Top] [All Lists]

[PATCH v3 5/8] xfs: create function to scan and clear EOFBLOCKS inodes

To: xfs@xxxxxxxxxxx
Subject: [PATCH v3 5/8] xfs: create function to scan and clear EOFBLOCKS inodes
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 14 Sep 2012 08:19:52 -0400
In-reply-to: <1347625195-6369-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1347625195-6369-1-git-send-email-bfoster@xxxxxxxxxx>
xfs_inodes_free_eofblocks() implements scanning functionality for
EOFBLOCKS inodes. It uses the AG iterator to walk the tagged inodes
and free post-EOF blocks via the xfs_inode_free_eofblocks() execute
function. The scan can be invoked in best-effort mode or wait
(force) mode.

A best-effort scan (default) handles all inodes that do not have a
dirty cache and we successfully acquire the io lock via trylock. In
wait mode, we continue to cycle through an AG until all inodes are
handled.

Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---
 fs/xfs/xfs_sync.c  |   40 ++++++++++++++++++++++++++++++++++++++++
 fs/xfs/xfs_sync.h  |    1 +
 fs/xfs/xfs_trace.h |    1 +
 3 files changed, 42 insertions(+), 0 deletions(-)

diff --git a/fs/xfs/xfs_sync.c b/fs/xfs/xfs_sync.c
index 0da93c9..48cab9f 100644
--- a/fs/xfs/xfs_sync.c
+++ b/fs/xfs/xfs_sync.c
@@ -1014,6 +1014,46 @@ xfs_reclaim_inodes_count(
        return reclaimable;
 }
 
+STATIC int
+xfs_inode_free_eofblocks(
+       struct xfs_inode        *ip,
+       struct xfs_perag        *pag,
+       int                     flags,
+       void                    *args)
+{
+       int ret;
+       bool force = flags & SYNC_WAIT;
+
+       if (!xfs_can_free_eofblocks(ip, false)) {
+               /* inode could be preallocated or append-only */
+               trace_xfs_inode_free_eofblocks_invalid(ip);
+               xfs_inode_clear_eofblocks_tag(ip);
+               return 0;
+       }
+
+       if (!force && mapping_tagged(VFS_I(ip)->i_mapping,
+                                    PAGECACHE_TAG_DIRTY))
+               return 0;
+
+       ret = xfs_free_eofblocks(ip->i_mount, ip, false);
+
+       /* ignore EAGAIN on a best effort scan */
+       if (!force && (ret == EAGAIN))
+               ret = 0;
+
+       return ret;
+}
+
+int
+xfs_inodes_free_eofblocks(
+       struct xfs_mount        *mp,
+       int                     flags)
+{
+       ASSERT((flags & ~(SYNC_TRYLOCK|SYNC_WAIT)) == 0);
+       return xfs_inode_ag_iterator_tag(mp, xfs_inode_free_eofblocks, flags,
+                                        NULL, XFS_ICI_EOFBLOCKS_TAG);
+}
+
 void
 xfs_inode_set_eofblocks_tag(
        xfs_inode_t     *ip)
diff --git a/fs/xfs/xfs_sync.h b/fs/xfs/xfs_sync.h
index 463ea0a..307654a 100644
--- a/fs/xfs/xfs_sync.h
+++ b/fs/xfs/xfs_sync.h
@@ -45,6 +45,7 @@ void __xfs_inode_clear_reclaim_tag(struct xfs_mount *mp, 
struct xfs_perag *pag,
 
 void xfs_inode_set_eofblocks_tag(struct xfs_inode *ip);
 void xfs_inode_clear_eofblocks_tag(struct xfs_inode *ip);
+int xfs_inodes_free_eofblocks(struct xfs_mount *, int);
 
 int xfs_sync_inode_grab(struct xfs_inode *ip);
 int xfs_inode_ag_iterator(struct xfs_mount *mp,
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 6f46e03..cb52346 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -589,6 +589,7 @@ DEFINE_INODE_EVENT(xfs_dquot_dqdetach);
 
 DEFINE_INODE_EVENT(xfs_inode_set_eofblocks_tag);
 DEFINE_INODE_EVENT(xfs_inode_clear_eofblocks_tag);
+DEFINE_INODE_EVENT(xfs_inode_free_eofblocks_invalid);
 
 DECLARE_EVENT_CLASS(xfs_iref_class,
        TP_PROTO(struct xfs_inode *ip, unsigned long caller_ip),
-- 
1.7.7.6

<Prev in Thread] Current Thread [Next in Thread>