xfs
[Top] [All Lists]

Re: xfs: stop the sync worker before xfs_unmountfs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs: stop the sync worker before xfs_unmountfs
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 13 Sep 2012 16:19:57 -0500
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120913081742.GA23181@xxxxxxxxxxxxx>
References: <20120829134624.316257238@xxxxxxx> <20120829134628.835024558@xxxxxxx> <20120830002335.GB15292@dastard> <20120830172549.GG3274@xxxxxxx> <20120830223504.GE15292@dastard> <5040FF25.1010501@xxxxxxx> <20120901230824.GB6896@xxxxxxxxxxxxx> <20120912183347.GO3274@xxxxxxx> <20120913081742.GA23181@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Sep 13, 2012 at 04:17:42AM -0400, Christoph Hellwig wrote:
> On Wed, Sep 12, 2012 at 01:33:47PM -0500, Ben Myers wrote:
> > See what you think of this.  Not heavily tested yet, and not pretty... but 
> > it
> > is fairly minimal. 
> > 
> > Pull startup and shutdown of the sync worker out of xfs_syncd_init and
> > xfs_syncd_stop into their callers.  In the case of unmount, move shutdown of
> > the xfs_sync_worker before teardown of the log in xfs_unmountfs.  This 
> > prevents
> > occasional crashes on unmount like so:
> > 
> > PID: 21602  TASK: ee9df060  CPU: 0   COMMAND: "kworker/0:3"                 
> >                                                                             
> >                                   
> >  #0 [c5377d28] crash_kexec at c0292c94                                      
> >                                                                             
> >                                   
> 
> Can you remove the trailing whitespaces in these lines?  They make
> reading the changelog on a normal 80 character wide terminal pretty
> hard.

Yeah.  Sorry about that.  Cleaned up.

> The changes look fine to me,
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks,
        Ben


<Prev in Thread] Current Thread [Next in Thread>