xfs
[Top] [All Lists]

Re: [PATCH] libxcmd: link against readline

To: Mike Frysinger <vapier@xxxxxxxxxx>
Subject: Re: [PATCH] libxcmd: link against readline
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 13 Sep 2012 10:30:07 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1345936050-15139-1-git-send-email-vapier@xxxxxxxxxx>
References: <1345936050-15139-1-git-send-email-vapier@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/25/12 18:07, Mike Frysinger wrote:
This library uses readline funcs (the input.c file), so we need to link
this shared library against it.

URL: https://bugs.gentoo.org/432644
Reported-by: David Badia<dbadia@xxxxxxxxx>
Signed-off-by: Mike Frysinger<vapier@xxxxxxxxxx>
---
  libxcmd/Makefile |    2 ++
  1 file changed, 2 insertions(+)

diff --git a/libxcmd/Makefile b/libxcmd/Makefile
index b3544f4..ce082a5 100644
--- a/libxcmd/Makefile
+++ b/libxcmd/Makefile
@@ -22,10 +22,12 @@ endif

  ifeq ($(ENABLE_READLINE),yes)
  LCFLAGS += -DENABLE_READLINE
+LTLIBS += $(LIBREADLINE) $(LIBTERMCAP)
  endif

  ifeq ($(ENABLE_EDITLINE),yes)
  LCFLAGS += -DENABLE_EDITLINE
+LTLIBS += $(LIBEDITLINE) $(LIBTERMCAP)
  endif

  default: ltdepend $(LTLIBRARY)

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>