xfs
[Top] [All Lists]

Re: [PATCH 2/3] XFS: Print error when xfs_ialloc_ag_select fails to find

To: raghu.prabhu13@xxxxxxxxx
Subject: Re: [PATCH 2/3] XFS: Print error when xfs_ialloc_ag_select fails to find continuous free space.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 12 Sep 2012 08:48:05 +1000
Cc: xfs@xxxxxxxxxxx, Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <b4227a4a67fb7b50bcf83fa369ba8999d3409d64.1347396641.git.rprabhu@xxxxxxxxxxx>
References: <cover.1347396641.git.rprabhu@xxxxxxxxxxx> <b4227a4a67fb7b50bcf83fa369ba8999d3409d64.1347396641.git.rprabhu@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 12, 2012 at 03:43:23AM +0530, raghu.prabhu13@xxxxxxxxx wrote:
> From: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
> 
> When xfs_ialloc_ag_select fails to find any AG with continuous free blocks
> required for inode allocation, printk the error in ratelimited manner.
> 
> Signed-off-by: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
> ---
>  fs/xfs/xfs_ialloc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
> index 5aceb3f..e75a39d 100644
> --- a/fs/xfs/xfs_ialloc.c
> +++ b/fs/xfs/xfs_ialloc.c
> @@ -539,8 +539,11 @@ nextag:
>               if (agno >= agcount)
>                       agno = 0;
>               if (agno == pagno) {
> -                     if (flags == 0)
> +                     if (flags == 0) {
> +                             xfs_err_ratelimited(mp,
> +                                     "Out of continuous free blocks for 
> inode allocation");

http://oss.sgi.com/archives/xfs/2012-06/msg00041.html

<quote>
Couple of things for all 3 patches. Firstly - 80 columns. We tend
to keep the pformat string on a single line so it is easy to grep
for like so:

                                pr_err_once(mp,
                "Insufficient contiguous free space for inode allocation");
</quote>

So, you need to change the error message to the one suggested, and
follow 80-character width limits like the rest of the code.

Also, I think the error message is better at the caller site, not in
the function itself. i.e. if we get a NULLAGNUMBER returned, the
caller decided whether to emit an error message or not.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>