[Top] [All Lists]

Re: [PATCH V3] xfstests: make 275 pass

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V3] xfstests: make 275 pass
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 8 Sep 2012 10:09:54 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, Eryu Guan <eguan@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, Zach Brown <zab@xxxxxxxxxx>
In-reply-to: <504A5176.5020302@xxxxxxxxxxx>
References: <4F04A6E6.1090304@xxxxxxxxxx> <4F04BC81.1000207@xxxxxxxxxx> <20120104231725.GB24466@dastard> <4F207079.6050401@xxxxxxxxxxx> <504A5176.5020302@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 07, 2012 at 02:56:38PM -0500, Eric Sandeen wrote:
> On 1/25/12 3:13 PM, Eric Sandeen wrote:
> > Ok, this is a significant rework of 275, which made too many
> > assumptions about details of space usage and failed on several
> > filesystems (it passed on xfs, but only by accident).
> > 
> > This new version tries to leave about 256k free, then tries
> > a single 1M IO, and fails only if 0 bytes are written.
> > 
> > It also sends a lot more to $seq.full for debugging on failure
> > and fixes a few other stylistic things.
> > 
> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> > ---
> Poor Zach ran into this one again.  Can I get a review of this
> version, and I'll merge it if it looks good?

Looks OK.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>