xfs
[Top] [All Lists]

Re: [PATCH 17/18] xfstests: convert tests to use new results directory

To: Boris Ranto <branto@xxxxxxxxxx>
Subject: Re: [PATCH 17/18] xfstests: convert tests to use new results directory
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 6 Sep 2012 09:04:31 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346846436.1129.20.camel@localhost>
References: <1343294892-20991-1-git-send-email-david@xxxxxxxxxxxxx> <1343294892-20991-18-git-send-email-david@xxxxxxxxxxxxx> <1346846436.1129.20.camel@localhost>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 05, 2012 at 02:00:35PM +0200, Boris Ranto wrote:
> On Thu, 2012-07-26 at 19:28 +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Essentially the change is simply this. Converting:
> > 
> > ... >> $seq.????
> > 
> > to:
> > 
> > .... >> $RESULT_DIR/$seq.????
> > 
> > so that output files are directed to the defined output directory.
> > 
> > sed to the rescue:
> > 
> > $ sed -i -e '/^seq=.*$/a seqres=$RESULT_DIR/$seq' -e 
> > 's/seq.full/seqres.full/' tests/*/*
> > 
> > will do most of the work automatically.
.....
> Quite a lot of tests use $here/$seq.full. This results in
> $here/$seqres.full after the sed. $seqres is just a $RESULT_DIR/$seq.
> This would break if RESULT_DIR was set to an absolute path instead of
> relative path.

Yes. As the patch description says it "will do most of the work",
but it doesn't do all of it. Indeed, supporting full paths for
$RESULT_DIR is actually necessary for other reasons, such as
supporting completely external result destinations. To that end, I
have a patch in my current series that does the rest of the
conversion with the appropriate setup changes:

commit 08dbbb1e6a82a4ed04e0622b7ee63957fae7721b
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Wed Aug 22 16:09:33 2012 +1000

    xfstests: RESULTS_DIR needs to be an absolute path
    
    
    Some tests 'cd <somedir>' and then direct output to $RESULT_DIR,
    which fails if the current working directory is not $here.
    Regardless, if an external results directory is to be used it needs
    to have a full path specified and the use of $here as the base of
    the results files is completely incorrect.
    
    Hence change all the $here/$seqres* references to simply be
    $seqres*, and instead encode the full path to the results in
    $RESULT_DIR.
    
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>