xfs
[Top] [All Lists]

Re: [PATCH 020/102] xfs: warn if direct reclaim tries to writeback pages

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 020/102] xfs: warn if direct reclaim tries to writeback pages
From: Mel Gorman <mgorman@xxxxxxx>
Date: Wed, 5 Sep 2012 12:32:42 +0100
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120827181742.GA13970@xxxxxxxxxxxxx>
References: <1345698180-13612-1-git-send-email-david@xxxxxxxxxxxxx> <1345698180-13612-21-git-send-email-david@xxxxxxxxxxxxx> <20120827181742.GA13970@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 27, 2012 at 02:17:42PM -0400, Christoph Hellwig wrote:
> On Thu, Aug 23, 2012 at 03:01:38PM +1000, Dave Chinner wrote:
> > From: Mel Gorman <mgorman@xxxxxxx>
> > 
> > Upstream commit: 94054fa3fca1fd78db02cb3d68d5627120f0a1d4
> > 
> > Direct reclaim should never writeback pages.  For now, handle the
> > situation and warn about it.  Ultimately, this will be a BUG_ON.
> 
> Is this actually the case on 3.0-stable?
> 

No, it is not. AFAIK, 3.0-stable does not contain [ee72886d: mm: vmscan:
do not writeback filesystem pages in direct reclaim] which is the absolute
minimum required for commit [94054fa3: xfs: warn if direct reclaim tries
to writeback pages] to make sense.

-- 
Mel Gorman
SUSE Labs

<Prev in Thread] Current Thread [Next in Thread>