xfs
[Top] [All Lists]

Re: [PATCH 13/13] xfs: remove xfs_iget.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 13/13] xfs: remove xfs_iget.c
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 04 Sep 2012 16:11:01 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-14-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-14-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/30/12 07:00, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The inode cache functions remaining in xfs_iget.c can be moved to xfs_icache.c
along with the other inode cache functions. This removes all functionality from
xfs_iget.c, so the file can simply be removed.

This move results in various functions now only having the scope of a single
file (e.g. xfs_inode_free()), so clean up all the definitions and exported
prototypes in xfs_icache.[ch] and xfs_inode.h appropriately.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>