| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Tue, 04 Sep 2012 16:07:52 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1346328017-2795-13-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-13-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 08/30/12 07:00, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> xfs_ilock() and friends really aren't related to the inode cache in any way, so move them to xfs_inode.c with all the other inode related functionality. While doing this move, move the xfs_ilock() tracepoints to *before* the lock is taken so that when a hang on a lock occurs we have events to indicate which process and what inode we were trying to lock when the hang occurred. This is much better than the current silence we get on a hang... Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch], Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 13/13] xfs: remove xfs_iget.c, Mark Tinguely |
| Previous by Thread: | Re: [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 13/13] xfs: remove xfs_iget.c, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |