xfs
[Top] [All Lists]

Re: [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like un

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 04 Sep 2012 16:04:34 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-11-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/30/12 07:00, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

xfs_quiesce_attr() is supposed to leave the log empty with an
unmount record written. Right now it does not wait for the AIL to be
emptied before writing the unmount record, not does it wait for
metadata IO completion, either. Fix it to use the same method and
code as xfs_log_unmount().

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>