xfs
[Top] [All Lists]

Re: [PATCH 05/13] xfs: sync work is now only periodic log work

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/13] xfs: sync work is now only periodic log work
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 04 Sep 2012 13:57:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/30/12 07:00, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The only thing the periodic sync work does now is flush the AIL and
idle the log. These are really functions of the log code, so move
the work to xfs_log.c and rename it appropriately.

The only wart that this leaves behind is the xfssyncd_centisecs
sysctl, otherwise the xfssyncd is dead. Clean up any comments that
related to xfssyncd to reflect it's passing.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

...


diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 7f4f937..598f279 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -34,6 +34,7 @@
  #include "xfs_dinode.h"
  #include "xfs_inode.h"
  #include "xfs_trace.h"
+#include "xfs_fsops.h"

  kmem_zone_t   *xfs_log_ticket_zone;

@@ -698,6 +699,8 @@ xfs_log_mount_finish(xfs_mount_t *mp)
                ASSERT(mp->m_flags&  XFS_MOUNT_RDONLY);
        }


Looking at this closer, shouldn't there be a check for recovery failure. If it did, the mount will stop:

        if (!error)

+       xfs_log_work_queue(mp);
+
        return error;
  }

--Mark.

<Prev in Thread] Current Thread [Next in Thread>