| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 04/13] xfs: don't run the sync work if the filesyste is read-only |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Tue, 04 Sep 2012 11:13:58 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1346328017-2795-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 08/30/12 07:00, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> If the filesytem is mounted or remounted read-only, stop the sync worker that tries to flush or cover the log if the filesystem is dirty. It's read-only, so it isn't dirty. Restart it on a remount,rw as necessary. This avoids the need for RO checks in the work. Similarly, stop the sync work when the filesystem is frozen, and start it again when the filesysetm is thawed. This avoids the need for special freeze checks in the work. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 01/13] xfs: xfs_syncd_stop must die, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 05/13] xfs: sync work is now only periodic log work, Mark Tinguely |
| Previous by Thread: | Re: [PATCH 0/5] Use libtool to install apps and remove relative lib paths, Ben Myers |
| Next by Thread: | Validate your email, email |
| Indexes: | [Date] [Thread] [Top] [All Lists] |