xfs
[Top] [All Lists]

Re: [PATCH 01/13] xfs: xfs_syncd_stop must die

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/13] xfs: xfs_syncd_stop must die
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 04 Sep 2012 11:10:14 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/30/12 07:00, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

xfs_syncd_start and xfs_syncd_stop tie a bunch of unrelated
functionailty together that actually have different start and stop
requirements. Kill these functions and open code the start/stop
methods for each of the background functions.

Subsequent patches will move the start/stop functions around to the
correct places to avoid races and shutdown issues.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>