xfs
[Top] [All Lists]

Re: [PATCH 3/5] xftests: Use installed libraries only

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH 3/5] xftests: Use installed libraries only
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Sep 2012 15:37:48 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120828172929.203767140@xxxxxxx>
References: <20120828172605.607853317@xxxxxxx> <20120828172929.203767140@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Aug 28, 2012 at 12:26:08PM -0500, Rich Johnston wrote:
> The xfstests autotools currently searches locally in
>    ../{acl,attr,dmapi,xfsprogs}
> for libraries that xfstests depends upon, in addition to searching for them in
> their regular installed locations on a system, e.g. /usr/lib.  It appears this
> feature was added (but not documented) so that xfs developers can build and 
> run
> xfstests without having to install the libraries.  This can lead to touble if

trouble.

(the subject also has a typo)

> you expect that xfstests is using the versions of the libraries installed on
> the system.
> 
> If a local library was found and not installed, libtool will create a wrapper
> script to call the binary from the .libs directory.  This patch will remove
> searching for local libraies so that the installed libraries are always used.
                      libraries

> Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 3/5] xftests: Use installed libraries only, Dave Chinner <=