xfs
[Top] [All Lists]

Re: [PATCH 02/13] xfs: rename the xfs_syncd workqueue

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/13] xfs: rename the xfs_syncd workqueue
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Sep 2012 13:09:58 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120901231722.GB27456@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-3-git-send-email-david@xxxxxxxxxxxxx> <20120901231722.GB27456@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Sep 01, 2012 at 07:17:22PM -0400, Christoph Hellwig wrote:
> On Thu, Aug 30, 2012 at 10:00:06PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > There is nothing "sync" realted to this work queue any more. It is a general
> > purpose per-filesystem work queue. Rename it appropriately, and remove the
> > "syncd" naming from various functions.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> With the current leight-weight workqueues I don't see why we'd even want
> a shared one for the different callers.  Let's move the patch until
> after killing xfs_flush_worker & co, and then add a workqueue for
> background and the log sync individually.

OK. It starts to make workqueues like slab caches - all the cool
kids have got one. :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>