xfs
[Top] [All Lists]

Re: [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 1 Sep 2012 19:30:40 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-13-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-13-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 30, 2012 at 10:00:16PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_ilock() and friends really aren't related to the inode cache in
> any way, so move them to xfs_inode.c with all the other inode
> related functionality.
> 
> While doing this move, move the xfs_ilock() tracepoints to *before*
> the lock is taken so that when a hang on a lock occurs we have
> events to indicate which process and what inode we were trying to
> lock when the hang occurred. This is much better than the current
> silence we get on a hang...

Looks good.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>