xfs
[Top] [All Lists]

Re: [PATCH 05/13] xfs: sync work is now only periodic log work

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/13] xfs: sync work is now only periodic log work
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 1 Sep 2012 19:23:43 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 30, 2012 at 10:00:09PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The only thing the periodic sync work does now is flush the AIL and
> idle the log. These are really functions of the log code, so move
> the work to xfs_log.c and rename it appropriately.
> 
> The only wart that this leaves behind is the xfssyncd_centisecs
> sysctl, otherwise the xfssyncd is dead. Clean up any comments that
> related to xfssyncd to reflect it's passing.

FYI: A while ago I looked into folding the work here into xfsaild.
While soing the periodic ail push there aka just waking up with a
timeout which we did more often anyway at that point was easy, getting
the log force / dummy log never really worked out.

I think at least the former probably should be dropped here as well.

<Prev in Thread] Current Thread [Next in Thread>