[Top] [All Lists]

Re: [PATCH 01/13] xfs: xfs_syncd_stop must die

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/13] xfs: xfs_syncd_stop must die
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 1 Sep 2012 19:15:21 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1346328017-2795-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 30, 2012 at 10:00:05PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> xfs_syncd_start and xfs_syncd_stop tie a bunch of unrelated
> functionailty together that actually have different start and stop
> requirements. Kill these functions and open code the start/stop
> methods for each of the background functions.
> Subsequent patches will move the start/stop functions around to the
> correct places to avoid races and shutdown issues.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>