[Top] [All Lists]

Re: [PATCH] xfs: flush workers before stopping log

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs: flush workers before stopping log
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 1 Sep 2012 19:08:24 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <5040FF25.1010501@xxxxxxx>
References: <20120829134624.316257238@xxxxxxx> <20120829134628.835024558@xxxxxxx> <20120830002335.GB15292@dastard> <20120830172549.GG3274@xxxxxxx> <20120830223504.GE15292@dastard> <5040FF25.1010501@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Aug 31, 2012 at 01:15:01PM -0500, Mark Tinguely wrote:
> I see your point on fixing problems in older branches when/if they
> are reported by an user. I am not glowing with pride with the patch,
> it is something that survived a week of testing that would cause a
> panic in a couple hours without the patch. Since we hit this problem
> with such frequency, that we wanted to push for a little proactive
> attention to prevent future panics.

I'd love to see a relatively minimal patch which can also be backported.
I also have to say that your patch as-is scares me a bit.  Everytime we
move the current xfs_sync_init/stop monsters around we created another
set of problems.  So I'd prefer at least taking the bits from Dave's
series that kill these helpers and do individual calls, and only move
those that are needed.   The other thing that I don't like about the
patch is that it causes assymetry in the mount/unmount path by moving
the stop into xfs_unmountfs but not the start into xfs_mountfs.  That
might be needed in some cases, but that should be some detailed comments
explaining why.

<Prev in Thread] Current Thread [Next in Thread>