xfs
[Top] [All Lists]

Re: [PATCH 06/18] xfstests: clean up and simply check CLI option parsing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/18] xfstests: clean up and simply check CLI option parsing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 28 Aug 2012 15:52:54 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1343294892-20991-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1343294892-20991-1-git-send-email-david@xxxxxxxxxxxxx> <1343294892-20991-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 26, 2012 at 07:28:00PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The option parise in a messy loop of option parsing and actions on
> secondary arguments. Turn it into something much neater and esay to
> understand rather than a mess of temporary variables and tortured
> logic...
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 06/18] xfstests: clean up and simply check CLI option parsing, Christoph Hellwig <=