xfs
[Top] [All Lists]

Re: [PATCH 10/10] xfstests: exclude largefs fill files from dump tests

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/10] xfstests: exclude largefs fill files from dump tests
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 28 Aug 2012 09:03:45 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1343291989-14987-11-git-send-email-david@xxxxxxxxxxxxx>
References: <1343291989-14987-1-git-send-email-david@xxxxxxxxxxxxx> <1343291989-14987-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 07/26/2012 03:39 AM, Dave Chinner wrote:
From: Dave Chinner <dchinner@xxxxxxxxxx>

The xfsdump/restore tests will see the space filling files and may
try to backthem up and restore them, consuming huge amounts of time
to do (espcially when diffing the results). Exclude the space
filling files by setting the no dump attributes on them and ensure
that xfsdump runs with the -e flag to exclude such files.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
  common.config |    3 ++-
  common.dump   |    2 +-
  common.rc     |    1 +
  3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/common.config b/common.config
index 7bed1c5..bb9af93 100644
--- a/common.config
+++ b/common.config
@@ -146,7 +146,8 @@ export XFS_GROWFS_PROG=`set_prog_path xfs_growfs`
  export XFS_IO_PROG="`set_prog_path xfs_io`"
  export XFS_PARALLEL_REPAIR_PROG="`set_prog_path xfs_prepair`"
  export XFS_PARALLEL_REPAIR64_PROG="`set_prog_path xfs_prepair64`"
-export XFSDUMP_PROG="`set_prog_path xfsdump`"
+export __XFSDUMP_PROG="`set_prog_path xfsdump`"
+export XFSDUMP_PROG="$__XFSDUMP_PROG -e"
  export XFSRESTORE_PROG="`set_prog_path xfsrestore`"
  export XFSINVUTIL_PROG="`set_prog_path xfsinvutil`"
  export DBENCH_PROG="`set_prog_path dbench`"
diff --git a/common.dump b/common.dump
index e89dedc..a33dc81 100644
--- a/common.dump
+++ b/common.dump
@@ -829,7 +829,7 @@ _dump_filter_main()
  {
    _filter_devchar |\
    sed \
-      -e "s#$XFSDUMP_PROG#xfsdump#"                  \
+      -e "s#$__XFSDUMP_PROG#xfsdump#"                        \
        -e "s#$XFSRESTORE_PROG#xfsrestore#"           \
        -e "s#$XFSINVUTIL_PROG#xfsinvutil#"           \
        -e "s/`hostname`/HOSTNAME/"                   \
diff --git a/common.rc b/common.rc
index 1c3c605..1b23b66 100644
--- a/common.rc
+++ b/common.rc
@@ -306,6 +306,7 @@ _setup_large_xfs_fs()
        xfs_io -F -f \
                -c "truncate $file_size" \
                -c "falloc -k 0 $file_size" \
+               -c "chattr +d" \
                $SCRATCH_MNT/.use_space 2>&1 > /dev/null
        status=$?
        umount $SCRATCH_MNT


Ditto my comments from patch 4, this does not work as expected when using the --large-fs option for the following tests:

        019 026-028 046 047 050 056 059 060 062-066

Regards
--Rich

<Prev in Thread] Current Thread [Next in Thread>