xfs
[Top] [All Lists]

Re: [RFE] xfstests: Add support for tmpfs filesystem

To: Boris Ranto <ranto.boris@xxxxxxxxx>
Subject: Re: [RFE] xfstests: Add support for tmpfs filesystem
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 24 Aug 2012 09:40:51 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <CAFZPdfipr3FkLJ3B7zDPXRA5Nw3Qerpri05gsnJopyMQwQfGUw@xxxxxxxxxxxxxx>
References: <CAFZPdfipr3FkLJ3B7zDPXRA5Nw3Qerpri05gsnJopyMQwQfGUw@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 23, 2012 at 10:42:56PM +0200, Boris Ranto wrote:
> This is resent with the improved subject line.
> This is just a simple patch to get the tmpfs working. I've made the full
> xfstests run with the tmpfs as the target filesystem and it works quite
> well. Some tests passed properly, some tests failed (and some of them due
> to the nature of tmpfs).
> 
> I didn't change the xfstests logic to recognize a proper SCRATCH_DEV so the
> SCRATCH_DEV for tmpfs should be in the nfs form (with the : in it) for this
> to work properly.

The patch format isn't quite right. it is normally:

 Subject: One-line description

 <description>

 Signed-off-by: ....

 ---
 <diff>

As it is, it would be nice if you could rebase this on top of my
series that reworks xfstests - all the option parsing is changed,
the common.rc file is now in common/rc, and so on.

>           fi
>           ;;
> +    tmpfs)
> +        if [ -z "$SCRATCH_DEV" -o ! -d "$SCRATCH_MNT" ];
> +        then
> +            _notrun "this test requires a valid \$SCRATCH_MNT and unique
> $SCRATCH_DEV"
> +        fi
> +        ;;

The patch also has line wrap issues.

> @@ -1552,6 +1604,10 @@ _cleanup_testdir()
>      # umount testdir as it is $SCRATCH_MNT which could be used by xfs next
>      [ -n "$testdir" ] && $UMOUNT_PROG $testdir
>      ;;
> +    tmpfs)
> +    # umount testdir since it is actually a scrath mount

scratch mount.

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>