xfs
[Top] [All Lists]

Re: xfstests: Replace lstat64 with cat in test 120

To: xfs@xxxxxxxxxxx
Subject: Re: xfstests: Replace lstat64 with cat in test 120
From: Alex Elder <elder@xxxxxxxxxxx>
Date: Wed, 22 Aug 2012 15:59:08 -0500
In-reply-to: <20120822185456.4F189B010E6D@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20120822185456.4F189B010E6D@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
On 08/22/2012 01:54 PM, Rich Johnston wrote:
> The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
> lstat64 in the src directory.  The wrapper calls the real binary created by
> libtool (.libs/lstat64)
> 
> Test 120 only copies src/lstat64 to $SCRATCH_MNT.  If a later version of
> libtool is used then only the wrapper is copied to $SCRATCH_MNT and the 
> wrapper
> will fail to find .libs/lstat64.
> 
>    ~/xfstests # diff 120.out 120.out.bad
>    /mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
>    This script is just a wrapper for lstat64.
>    See the libtool documentation for more information.
> 
> This patch copies /usr/bin/cat (which is readily availible on unix systems) to
> $SCRATCH_MNT instead of src/lstat64.

I was going to suggest you use /bin/cat instead, but it appears
the actual patch does.

Please update your description.  Otherwise, looks good to me.

Reviewed-by: Alex Elder <elder@xxxxxxxxxxx>

> 
> Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>
> 
> ---
>  120 |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Index: b/120
> ===================================================================
> --- a/120
> +++ b/120
> @@ -68,12 +68,12 @@ fi
>  
>  #executable file
>  echo "*** copying file ***"
> -cp src/lstat64 $SCRATCH_MNT
> -src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
> +cp /bin/cat $SCRATCH_MNT
> +src/lstat64 $SCRATCH_MNT/cat >$tmp.out
>  sleep 5
>  echo "*** executing file ***"
> -$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
> -_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
> +$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
> +_compare_access_times $SCRATCH_MNT/cat "executing file"
>  
>  #reading file
>  echo "*** creating file ***"
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>