xfs
[Top] [All Lists]

Re: [PATCH] xfs: minor inode64 mount option cleanup

To: Alex Elder <elder@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: minor inode64 mount option cleanup
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Aug 2012 08:23:29 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <501943B5.4030309@xxxxxxxxxxx>
References: <501943B5.4030309@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> @@ -295,12 +295,13 @@ xfs_parseargs(
>                       }
>                       dswidth = simple_strtoul(value, &eov, 10);
>               } else if (!strcmp(this_char, MNTOPT_64BITINODE)) {
> +#if XFS_BIG_INUMS
>                       mp->m_flags &= ~XFS_MOUNT_SMALL_INUMS;
> -#if !XFS_BIG_INUMS
> +#else /* !XFS_BIG_INUMS */

Looks good for now, but in the long run I'd prefer thast XFS simplify
requires 64-bit block numbers like gfs2 as there's not too much of a
point using it in a super-constrained envrionment and we could kill
all the XFS_BIG_INUMS conditionals, as well as the types that are
different based on the in-memory block number size.

<Prev in Thread] Current Thread [Next in Thread>