xfs
[Top] [All Lists]

Re: [PATCH] xfs: unlock the AGI buffer when looping in xfs_dialloc

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: unlock the AGI buffer when looping in xfs_dialloc
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 16 Aug 2012 15:53:26 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120807060202.GA4005@xxxxxxxxxxxxx>
References: <20120807060202.GA4005@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Christoph,

On Tue, Aug 07, 2012 at 02:02:02AM -0400, Christoph Hellwig wrote:
> Also update some commens in the area to make the code easier to read.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This seems to fix a regression that was introduced in

commit 55d6af64, 'xfs: refactor xfs_ialloc_ag_select'

Christoph, could you comment on why this has not caused problems in testing?  I
am sort of suprised we haven't had any ill effects.

I'll add this patch into our next pull request.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>