xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfstests: speed up 227 by using preallocation

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfstests: speed up 227 by using preallocation
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 16 Aug 2012 14:16:41 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1343291706-14882-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1343291706-14882-1-git-send-email-david@xxxxxxxxxxxxx> <1343291706-14882-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 07/26/2012 03:35 AM, Dave Chinner wrote:
From: Dave Chinner <dchinner@xxxxxxxxxx>

Test 227 (fsr test) creates fragmented fre space by doing lots of
small writes to sparse offsets ni a file. This seeks the disk heads
around a lot writing data. We don't need to write data - just
trigger allocation. Hence use preallocation instead of data writes
and run at allocation speed rather than data write speed.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
  227 |   46 +++++++++++++++++++++++++++++++++-------------
  1 file changed, 33 insertions(+), 13 deletions(-)

Looks good to me.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>