xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfstests: test 110 sometimes fails to unmount scratch de

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfstests: test 110 sometimes fails to unmount scratch dev
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 16 Aug 2012 14:16:19 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1343291706-14882-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1343291706-14882-1-git-send-email-david@xxxxxxxxxxxxx> <1343291706-14882-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 07/26/2012 03:35 AM, Dave Chinner wrote:
From: Dave Chinner <dchinner@xxxxxxxxxx>

It runs a bunch of rm processes in the background, then immediately
calls _check_scratch_fs without waiting for them to complete, hence
the unmount can fail with a busy filesystem error.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
  110 |    1 +
  1 file changed, 1 insertion(+)

diff --git a/110 b/110
index aad5835..c58e6c9 100755
--- a/110
+++ b/110
@@ -69,6 +69,7 @@ do
      let I=$I+1
      [ $[$I % 1000] -eq 0 ] && echo "Created $I/$E"
  done
#RCJ Yes wait for rm processes to complete
+wait

  sync


Looks good to me.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>