| To: | Alex Elder <elder@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: kill struct declarations in xfs_mount.h |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Thu, 16 Aug 2012 13:24:40 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <501943B1.5090300@xxxxxxxxxxx> |
| References: | <501943B1.5090300@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Wed, Aug 01, 2012 at 09:56:49AM -0500, Alex Elder wrote: > I noticed that "struct xfs_mount_args" was still declared in > "fs/xfs/xfs_mount.h". That struct doesn't even exist any more (and > is obviously not referenced elsewhere in that header file). While > in there, delete four other unneeded struct declarations in that > file. > > Doing so highlights that "fs/xfs/xfs_trace.h" was relying indirectly > on "xfs_mount.h" to be #included in order to declare "struct > xfs_bmbt_irec", so add that declaration to resolve that issue. > > Signed-off-by: Alex Elder <elder@xxxxxxxxxxx> Looks fine to me. Reviewed-by: Ben Myers <bpm@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: fix uninitialised variable in xfs_rtbuf_get(), Ben Myers |
|---|---|
| Next by Date: | [PATCH] Make inode64 a remountable option, Carlos Maiolino |
| Previous by Thread: | [PATCH] xfs: kill struct declarations in xfs_mount.h, Alex Elder |
| Next by Thread: | Re: [PATCH] xfs: kill struct declarations in xfs_mount.h, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |