[Top] [All Lists]

Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 15 Aug 2012 12:23:01 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120814213929.GN2877@dastard>
References: <1343294892-20991-1-git-send-email-david@xxxxxxxxxxxxx> <20120814213929.GN2877@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/14/12 16:39, Dave Chinner wrote:

On Thu, Jul 26, 2012 at 07:27:54PM +1000, Dave Chinner wrote:
Alt-Subject: Games with Sed, Grep and Awk.

This series is based on top of the large filesystem test series.

This moves all the tests into a ./tests subdirectory, and sorts them into
classes of related tests. Those are:

        tests/generic:  valid for all filesystems
        tests/shared:   valid for a limited number of filesystems
        tests/xfs:      xfs specific tests
        tests/btrfs     btrfs specific tests
        tests/ext4      ext4 specific tests
        tests/udf       udf specific tests

Each directory has it's own group file to determine what groups the
tests are associated with. Tests are run in exactly the same was as
before, but when trying to run individual tests you need to specify
the class as well. e.g. the old way:

# ./check 001

The new way:

# ./check generic/001

I applied the series and started a closer look. I like what you have done.

As far as RFC, the only concern that I have heard so far is the desire to see benchmarking in the test suite.


<Prev in Thread] Current Thread [Next in Thread>