xfs
[Top] [All Lists]

Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim

To: Tomas Racek <tracek@xxxxxxxxxx>
Subject: Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 15 Aug 2012 09:02:00 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx, Alex Elder <elder@xxxxxxxxxx>
In-reply-to: <1805964222.1573527.1345033412870.JavaMail.root@xxxxxxxxxx>
References: <20120814213629.GL2877@dastard> <1805964222.1573527.1345033412870.JavaMail.root@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Aug 15, 2012 at 08:23:32AM -0400, Tomas Racek wrote:
> Forwarding to maintainers.

Thanks Tomas.  We'll get this sorted.

Regards,
        Ben

> 
> ----- Original Message -----
> > On Tue, Aug 14, 2012 at 10:35:04AM +0200, Tomas Racek wrote:
> > > If range.start or range.minlen is bigger than filesystem size,
> > > return
> > > invalid value error. This fixes possible overflow in BTOBB macro
> > > when
> > > passed value was nearly ULLONG_MAX.
> > > 
> > > Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>
> > 
> > looks ok to me.
> > 
> > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > --
> > Dave Chinner
> > david@xxxxxxxxxxxxx
> > 

<Prev in Thread] Current Thread [Next in Thread>