| To: | Tomas Racek <tracek@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfstests: Use upstream version of fstrim instead of the local one |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 15 Aug 2012 07:39:11 +1000 |
| Cc: | xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx |
| In-reply-to: | <1344937201-17389-1-git-send-email-tracek@xxxxxxxxxx> |
| References: | <1344937201-17389-1-git-send-email-tracek@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Aug 14, 2012 at 11:40:01AM +0200, Tomas Racek wrote: > Local version of fstrim was dropped so that we depend on upstream > version now. _require_fstrim was added to check if fstrim is available > in the system and _test_batched_discard to check if we can run fstrim > on certain mountpoint. > > Also tests 251 and 260 were modified to reflect this change. Looks OK, but the only thing I'd suggest is using a $FSTRIM_PROG variable rather than fsttrim directly. see how $XFS_IO_PROG is set up in common.rc and copy that. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v4] xfs: check for possible overflow in xfs_ioc_trim, Dave Chinner |
|---|---|
| Next by Date: | Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level, Dave Chinner |
| Previous by Thread: | [PATCH v2] xfstests: Use upstream version of fstrim instead of the local one, Tomas Racek |
| Next by Thread: | Ihr Amazon Konto wurde gesperrt, Amazon.de |
| Indexes: | [Date] [Thread] [Top] [All Lists] |