xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when creating new script
From: Tomas Racek <tracek@xxxxxxxxxx>
Date: Tue, 31 Jul 2012 06:41:12 -0400 (EDT)
Cc: xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx
In-reply-to: <20120730215630.GH2877@dastard>
> > 
> >    #  Mandatory Config values.
> >    MC=""
> > -  [ -z "$EMAIL" ]          && MC="$MC EMAIL"
> > -  [ -z "$TEST_DIR" ]       && MC="$MC TEST_DIR"
> > -  [ -z "$TEST_DEV" ]       && MC="$MC TEST_DEV"
> > +  [ -z "$EMAIL" ]                           && MC="$MC EMAIL"
> > +  [ -z "$TEST_DIR" ] && [ "$iam" != "new" ] && MC="$MC TEST_DIR"
> > +  [ -z "$TEST_DEV" ] && [ "$iam" != "new" ] && MC="$MC TEST_DEV"
> 
> Given that I'm currently in the process of killing $iam as I
> rework the structure of xfstests, I really don't like the idea of
> introducing new dependencies on it.

OK, I didn't know that. ;-)

> Also, I prefer to know that someone writing a new test is developing
> it in a configured, working test environment. After all, you have to
> test your new test as you write it... :p

I thought that is not necessary to depend on those if new script doesn't 
require them but I can see your point.

Thanks for comments!

Tomas

<Prev in Thread] Current Thread [Next in Thread>