xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Change fstrim behaviour to be consistent with upst

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Change fstrim behaviour to be consistent with upstream version
From: Tomas Racek <tracek@xxxxxxxxxx>
Date: Tue, 31 Jul 2012 06:24:26 -0400 (EDT)
Cc: lczerner@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120730220413.GI2877@dastard>
> If we have duplicate code (i.e. a copy of the upstream utility) or
> the local tool can be completely replaced by the upstream tool,
> then we should use upstream and remove the local copy completely.
> Distros have been shipping fstrim for long enough now that most
> people running testing on upstream kernels will have it installed...
> 

OK, I'll create the patch which drops local version.

> Adding a _require_fstrim() function that checks for the upstream
> version of fstrim to be installed for each test that requires it
> would go along with this.

Did you mean something like

_require_fstrim()
{
         which fstrim &>/dev/null || _notrun "This test requires fstrim 
utility."
}

in common.rc or locally in each test?

Thanks for comments!

Tomas

<Prev in Thread] Current Thread [Next in Thread>