[Top] [All Lists]

Re: [PATCH] xfstests: Change fstrim behaviour to be consistent with upst

To: Tomas Racek <tracek@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Change fstrim behaviour to be consistent with upstream version
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 31 Jul 2012 08:04:13 +1000
Cc: xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx
In-reply-to: <1343649963-14079-1-git-send-email-tracek@xxxxxxxxxx>
References: <1343649963-14079-1-git-send-email-tracek@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 30, 2012 at 02:06:03PM +0200, Tomas Racek wrote:
> Rename fstrim option from "-s" to "-o" and change output message when
> verbose option is set.

Why modify a local utility program like this?  There's little point
in trying to match some other utilities' command line parameters
just for the sake of it...

If we have duplicate code (i.e. a copy of the upstream utility) or
the local tool can be completely replaced by the upstream tool,
then we should use upstream and remove the local copy completely.
Distros have been shipping fstrim for long enough now that most
people running testing on upstream kernels will have it installed...

Adding a _require_fstrim() function that checks for the upstream
version of fstrim to be installed for each test that requires it
would go along with this.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>